Skip to content

lib, doc: Float16Array cleanup and typo fixes #62542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parsherr wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −9
Open

lib, doc: Float16Array cleanup and typo fixes #62542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fd4860
lib: update Float16Array primordials and comparisons
parsherr Apr 1, 2026
0d2f4fb
doc: fix typos and update MDN links for disposables
parsherr Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1609,7 +1609,7 @@ Both this function and the disposal function on the resulting object are
async, so it should be used with `await` + `await using` as in
`await using dir = await fsPromises.mkdtempDisposable('prefix')`.

<!-- TODO: link MDN docs for disposables once https://github.com/mdn/content/pull/38027 lands -->
For more information, see [MDN's documentation for Explicit Resource Management](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/using).

For detailed information, see the documentation of [`fsPromises.mkdtemp()`][].

Expand Down Expand Up @@ -6259,7 +6259,7 @@ removed if it still exists. If the directory cannot be deleted, disposal will
throw an error. The object has a `remove()` method which will perform the same
task.

<!-- TODO: link MDN docs for disposables once https://github.com/mdn/content/pull/38027 lands -->
For more information, see [MDN's documentation for Explicit Resource Management](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/using).

For detailed information, see the documentation of [`fs.mkdtemp()`][].

Expand Down
2 changes: 1 addition & 1 deletion doc/api/stream_iter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1588,7 +1588,7 @@ console.log(ready); // Promise { true } -- no backpressure
* Value: `Symbol.for('Stream.shareProtocol')`

The value must be a function. When called by `Share.from()`, it receives the
options passed to `Share.from()` and must return an object conforming the the
options passed to `Share.from()` and must return an object conforming to the
{Share} interface. The implementation is fully custom -- it can manage the shared
source, consumers, buffering, and backpressure however it wants.

Expand Down
2 changes: 1 addition & 1 deletion doc/api/util.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2551,7 +2551,7 @@ changes:

* `format` {string | Array} A text format or an Array
of text formats defined in `util.inspect.colors`.
* `text` {string} The text to to be formatted.
* `text` {string} The text to be formatted.
* `options` {Object}
* `validateStream` {boolean} When true, `stream` is checked to see if it can handle colors. **Default:** `true`.
* `stream` {Stream} A stream that will be validated if it can be colored. **Default:** `process.stdout`.
Expand Down
1 change: 1 addition & 0 deletions lib/internal/per_context/primordials.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ function copyPrototype(src, dest, prefix) {
'Error',
'EvalError',
'FinalizationRegistry',
'Float16Array',
Copy link
Copy Markdown
Member

@Renegade334 Renegade334 Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an optional flagged feature in V8. This change crashes the snapshot generator, and segfaults the Node.js process on startup with --no-js-float16array. This is the reason why it is not in primordials, the same as other optional components such as SharedArrayBuffer.

Please revert the lib changes. (The doc changes LGTM.)

'Float32Array',
'Float64Array',
'Function',
Expand Down
7 changes: 2 additions & 5 deletions lib/internal/util/comparisons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const {
Date,
DatePrototypeGetTime,
Error,
Float16Array,
Float32Array,
Float64Array,
Function,
Expand Down Expand Up @@ -50,7 +51,6 @@ const {
Uint8ClampedArray,
WeakMap,
WeakSet,
globalThis: { Float16Array },
} = primordials;

const { compare } = internalBinding('buffer');
Expand All @@ -70,6 +70,7 @@ const wellKnownConstructors = new SafeSet()
.add(DataView)
.add(Date)
.add(Error)
.add(Float16Array)
.add(Float32Array)
.add(Float64Array)
.add(Function)
Expand All @@ -91,10 +92,6 @@ const wellKnownConstructors = new SafeSet()
.add(WeakMap)
.add(WeakSet);

if (Float16Array) { // TODO(BridgeAR): Remove when Flag got removed from V8
wellKnownConstructors.add(Float16Array);
}

const types = require('internal/util/types');
const {
isAnyArrayBuffer,
Expand Down
Loading