lib, doc: Float16Array cleanup and typo fixes#62542
Open
parsherr wants to merge 2 commits intonodejs:mainfrom
Open
lib, doc: Float16Array cleanup and typo fixes#62542parsherr wants to merge 2 commits intonodejs:mainfrom
parsherr wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
Renegade334
requested changes
Apr 1, 2026
| 'Error', | ||
| 'EvalError', | ||
| 'FinalizationRegistry', | ||
| 'Float16Array', |
Member
There was a problem hiding this comment.
This is an optional flagged feature in V8. This change crashes the snapshot generator, and segfaults the Node.js process on startup with --no-js-float16array. This is the reason why it is not in primordials, the same as other optional components such as SharedArrayBuffer.
Please revert the lib changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains several small improvements:\n1. lib: make Float16Array a first-class primordial in comparisons.js and lib/internal/per_context/primordials.js\n2. doc: fix typos in stream_iter.md and util.md\n3. doc: link MDN docs for disposables in fs.md