Open
Conversation
Member
Author
|
Some minor changes from the PR this was based on:
|
This comment has been minimized.
This comment has been minimized.
This was referenced Mar 24, 2026
4357c17 to
aeb531f
Compare
## Summary of the Pull Request Targets #20010 Manually assign an AUMID to our process when we're running unpackaged. Main difference from #19937 is what AUMID we use. Before, it was per branding, but the `WindowEmperor` already appends an exe path hash for unpackaged instances to prevent crosstalk. Here, we're just using the same pattern: `Microsoft.WindowsTerminal.<hash>`. Heavily based on #19937 Co-authored by @zadjii-msft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds the infrastructure for toast notifications. Breakdown:
DesktopNotification:DesktopNotificationArgsincludes the struct to group all notification-related data together.SendNotification()actually sends itAppCommandlineArgs.cpp: added a check for the__fromToastno-op sentinelTerminalPaneContenttoTerminalPageTabManagement.cpp:_SendDesktopNotification()does the final packaging of the notification before calling theDesktopNotificationAPIThis simply adds the infrastructure! Looks like nothing can actually take advantage of it yet
Heavily based on #19935
Co-authored by @zadjii-msft