Add support for OSC777 (Send Notification)#20012
Open
carlos-zamora wants to merge 4 commits intodev/cazamor/toast/basefrom
Open
Add support for OSC777 (Send Notification)#20012carlos-zamora wants to merge 4 commits intodev/cazamor/toast/basefrom
carlos-zamora wants to merge 4 commits intodev/cazamor/toast/basefrom
Conversation
lhecker
reviewed
Mar 25, 2026
| const auto title = parts.size() >= 2 ? til::at(parts, 1) : std::wstring_view{}; | ||
| const auto body = parts.size() >= 3 ? til::at(parts, 2) : std::wstring_view{}; | ||
| _api.ShowNotification(title, body); | ||
| } |
Member
There was a problem hiding this comment.
After #20009 merged yesterday, I think this now needs an:
else
{
_api.UnknownSequence();
}
Member
Author
There was a problem hiding this comment.
Good catch. I never would've caught this haha
Member
Author
There was a problem hiding this comment.
Do we need another one of those here?
terminal/src/terminal/adapter/adaptDispatch.cpp
Lines 3854 to 3857 in 34b985d
| { | ||
| _dispatch->DoDesktopNotification(string); | ||
| break; | ||
| } |
Member
There was a problem hiding this comment.
FWIW, you can drop those braces here.
carlos-zamora
force-pushed
the
dev/cazamor/toast/base
branch
from
4357c17 to
aeb531f
Compare
carlos-zamora
force-pushed
the
dev/cazamor/toast/osc777
branch
from
2f5763e to
34b985d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
carlos-zamora
force-pushed
the
dev/cazamor/toast/osc777
branch
from
34b985d to
7ea4f2f
Compare
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
targets #20010
This adds support for the
OSC 777 ; notify ; title ; body STsequence. This allows client applications to send a notification to the Terminal. When this notification is clicked, it summons the terminal window that sent it.Validation Steps Performed
PR Checklist
Heavily based on #19938
Co-authored by @zadjii-msft