Skip to content

Add tools to test LXATAC features and speedup bringup.#107

Merged
hnez merged 5 commits into
linux-automation:mainfrom
lichtfeind:bringup-tooling
May 8, 2026
Merged

Add tools to test LXATAC features and speedup bringup.#107
hnez merged 5 commits into
linux-automation:mainfrom
lichtfeind:bringup-tooling

Conversation

@lichtfeind
Copy link
Copy Markdown

To speedup bring up of the LXATAC this adds a second binary to collect ADC statistics and test LEDs, display and buttons.

To do this i needed to change the visibility of some structs/types/functions. And add color support.
The color support is probably still flaky as i am unsure how how to check for the color space used by the frame buffer.
It is also still missing color support the the Display view in the web ui.

The ADC part allows to collect ADC samples from multiple channels interleaved. This make measurements hopefully more correlated then the old way of collecting then separately.

The LED,Display ui test display a rainbow on the LCD and cycles the LEDs and LCD backlight when a button is pressed.
After both buttons have registered a press the ui-test will exit. (as this is only tested every ~5 press it might take some addition presses)

@hnez
Copy link
Copy Markdown
Member

hnez commented Apr 21, 2026

Hi,

some high level stuff I have noticed first:

  • It was me who suggested building two distinct binaries, but maybe we should rethink that decision, as it leads to a lot of dead code warnings which we would have to work around. How about building one tacd binary instead, that can be the daemon (tacd daemon or plain tacd) and also tacd selftest (or whatever better name we come up with for this feature).

  • The change to RGB color on the display is quite invasive for what you want to achieve (displaying color in selfest mode) and I am not too stoked about changing the framebuffer handling, because it has broken before due to changes on what the framebuffer emulation in the kernel has given us. Could'nt you get away with just writing to the Framebuffer struct directly in the selftest mode to display color?

      display.with_lock(|target| {
          // Do something with `target.0.frame`
      });
  • I would prefer the last commit to be split up into smaller changes for better reviewability.

Comment thread src/main-testing.rs Outdated
Comment thread src/main-testing.rs Outdated
Comment thread src/main-testing.rs Outdated
Comment thread src/main-testing.rs Outdated
Comment thread src/main-testing.rs Outdated
@lichtfeind lichtfeind force-pushed the bringup-tooling branch 2 times, most recently from 39bb0e6 to e105d19 Compare May 4, 2026 10:12
Comment thread src/adc/iio/demo_mode.rs
Comment thread src/adc/iio/hardware.rs Outdated
Comment thread src/selftest/adc.rs Outdated
Comment thread src/selftest/adc.rs Outdated
Comment thread src/selftest/ui.rs
Comment thread src/selftest/ui.rs Outdated
Comment thread src/selftest/ui.rs Outdated
Comment thread src/selftest/ui.rs Outdated
Comment thread src/selftest/ui.rs
Comment thread src/selftest/ui.rs Outdated
Comment thread src/selftest/ui.rs
Comment thread src/selftest/ui.rs Outdated
Comment thread src/selftest/ui.rs Outdated
Comment thread src/main.rs Outdated
Comment thread src/main.rs
Comment thread src/selftest.rs Outdated
Comment thread src/measurement.rs
Comment thread src/selftest/ui.rs
@hnez
Copy link
Copy Markdown
Member

hnez commented May 5, 2026

We are quickly getting there. Please have a look at some of the remaining comments I had, feel free to dismiss some of them as nitpicking, if you think so, and rebase the changes into a clean format that we can merge.

Signed-off-by: Jonas Martin <jma@pengutronix.de>
Jonas Martin added 3 commits May 6, 2026 11:31
Signed-off-by: Jonas Martin <jma@pengutronix.de>
Signed-off-by: Jonas Martin <jma@pengutronix.de>
Signed-off-by: Jonas Martin <jma@pengutronix.de>
Signed-off-by: Jonas Martin <jma@pengutronix.de>
@hnez hnez marked this pull request as ready for review May 6, 2026 10:59
@hnez hnez merged commit bcc0e06 into linux-automation:main May 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants