Skip to content

PortableRunner tests: surface worker-thread exceptions on main thread after wait_until_finish() (fixes #35211) #36485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damccorm merged 3 commits into from
Oct 16, 2025
Merged

PortableRunner tests: surface worker-thread exceptions on main thread after wait_until_finish() (fixes #35211) #36485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a26f249
fix, yapf, pylintt, isort
jh1231223 Sep 25, 2025
17aa2c9
portable-runner: re-raise worker errors in wait_until_finish
jh1231223 Oct 15, 2025
bb8f410
Revert fn_runner_test.py to origin/master
jh1231223 Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion sdks/python/apache_beam/runners/portability/local_job_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,6 @@ def _run_job(self):
message_text=traceback.format_exc()))
_LOGGER.exception('Error running pipeline.')
self.set_state(beam_job_api_pb2.JobState.FAILED)
raise

def _invoke_runner(self):
self.set_state(beam_job_api_pb2.JobState.RUNNING)
Expand Down
14 changes: 10 additions & 4 deletions sdks/python/apache_beam/runners/portability/portable_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,14 +528,17 @@ def wait_until_finish(self, duration=None):
the execution. If None or zero, will wait until the pipeline finishes.
:return: The result of the pipeline, i.e. PipelineResult.
"""
last_error_text = None

def read_messages() -> None:
nonlocal last_error_text
previous_state = -1
for message in self._message_stream:
if message.HasField('message_response'):
logging.log(
MESSAGE_LOG_LEVELS[message.message_response.importance],
"%s",
message.message_response.message_text)
mr = message.message_response
logging.log(MESSAGE_LOG_LEVELS[mr.importance], "%s", mr.message_text)
if mr.importance == beam_job_api_pb2.JobMessage.JOB_MESSAGE_ERROR:
last_error_text = mr.message_text
else:
current_state = message.state_response.state
if current_state != previous_state:
Expand Down Expand Up @@ -566,6 +569,9 @@ def read_messages() -> None:

if self._runtime_exception:
raise self._runtime_exception
from apache_beam.runners.runner import PipelineState
if self._state == PipelineState.FAILED:
raise RuntimeError(last_error_text or "Pipeline failed.")

return self._state

Expand Down
Loading