Skip to content

Fix segfault when opening SF2 Player GUI during load #8227 #8322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BernardoMalheiro wants to merge 2 commits into
base: master
Choose a base branch
from
+14 −0
Open

Fix segfault when opening SF2 Player GUI during load #8227 #8322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd7e7a
Fix #8227: prevent segfault when opening SF2 Player GUI during load
BernardoMalheiro Mar 21, 2026
a9f8abb
Address reviewer feedback on SF2 Player GUI fix
BernardoMalheiro Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions include/InstrumentTrackView.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ class InstrumentTrackView : public TrackView


private slots:
void onInstrumentChanged();
void toggleInstrumentWindow( bool _on );
void toggleMidiCCRack();
void activityIndicatorPressed();
Expand Down
13 changes: 13 additions & 0 deletions src/gui/tracks/InstrumentTrackView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ InstrumentTrackView::InstrumentTrackView( InstrumentTrack * _it, TrackContainerV
connect(ConfigManager::inst(), SIGNAL(valueChanged(QString,QString,QString)),
this, SLOT(handleConfigChange(QString,QString,QString)));

connect(_it, &InstrumentTrack::instrumentChanged, this, &InstrumentTrackView::onInstrumentChanged);

m_mixerChannelNumber = new MixerChannelLcdSpinBox(2, getTrackSettingsWidget(), tr("Mixer channel"), this);
m_mixerChannelNumber->show();

Expand Down Expand Up @@ -167,6 +169,8 @@ InstrumentTrackView::InstrumentTrackView( InstrumentTrack * _it, TrackContainerV
m_activityIndicator, SLOT(noteEnd()));

setModel( _it );

onInstrumentChanged();
}


Expand Down Expand Up @@ -300,6 +304,15 @@ void InstrumentTrackView::dropEvent( QDropEvent * _de )



void InstrumentTrackView::onInstrumentChanged()
{
// Check if an instrument has been loaded, if not disable the track label button to prevent opening an empty instrument window.
m_tlb->setEnabled(model()->m_instrument != nullptr);
}




void InstrumentTrackView::toggleInstrumentWindow( bool _on )
{
if (_on && ConfigManager::inst()->value("ui", "oneinstrumenttrackwindow").toInt())
Expand Down
Loading