Fix segfault when opening SF2 Player GUI during load #8227#8322
Open
BernardoMalheiro wants to merge 2 commits into
Open
Fix segfault when opening SF2 Player GUI during load #8227#8322BernardoMalheiro wants to merge 2 commits into
BernardoMalheiro wants to merge 2 commits into
Conversation
Root cause: - clicking the TrackLabelButton while a soundfont was still loading triggered InstrumentTrackWindow::adjustTabSize() with a null widget pointer, causing a segmentation fault Changes: - disable TrackLabelButton in constructor when no instrument is loaded - re-enable TrackLabelButton via onInstrumentChanged() slot connected to InstrumentTrack::instrumentChanged() signal - add null guard in adjustTabSize() as an additional safety measure
rubiefawn
requested changes
Mar 23, 2026
Contributor
rubiefawn
left a comment
rubiefawn
left a comment
There was a problem hiding this comment.
I haven't yet tested this fix. I'll update this comment when I do.
- Refine button state logic: Updated the implementation to follow the specific architectural pattern suggested during review. - Code style adjustments: Cleaned up spacing to better match the project's guidelines. - Removed null checks that were identified as unnecessary by the maintainers.
Author
|
Hi @rubiefawn! It's been about a month since I pushed the follow-up addressing your review. I removed the Doxygen comments, dropped the null guard, replaced the constructor logic with onInstrumentChanged(), and updated the connect() call to use the new Qt5 pointer-to-member syntax. Would you have time to take another look when you get a chance? Happy to make further adjustments if needed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking the
TrackLabelButtonwhile a soundfont was still loading triggeredInstrumentTrackWindow::adjustTabSize()with a null widget pointer, causing a segmentation fault.Changes:
TrackLabelButtonin constructor when no instrument is loadedTrackLabelButtonviaonInstrumentChanged()slot connected toInstrumentTrack::instrumentChanged()signaladjustTabSize()as an additional safety measureCloses #8227