Exposing reference to the Widget through an optional variable#33
Open
sirphoenix wants to merge 7 commits intozouhir:masterfrom
Open
Exposing reference to the Widget through an optional variable#33sirphoenix wants to merge 7 commits intozouhir:masterfrom
sirphoenix wants to merge 7 commits intozouhir:masterfrom
Conversation
|
@sirphoenix can these changes be used to make a widget that can show/hide based on a click's on the host element? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new "component" parameter to the render() function which can be either a string or object.
When passing a string like 'foo' the reference will be set to window[foo].
When passing an object it will set its property 'ref' to the widgets reference.
Also made some code cleanup since there were no eslint-settings to be found.