fix: replace context.TODO() with context.Background() in 6 fire-and-forget call sites#99
Open
KorsarOfficial wants to merge 2 commits intoyandex:mainfrom
Open
fix: replace context.TODO() with context.Background() in 6 fire-and-forget call sites#99KorsarOfficial wants to merge 2 commits intoyandex:mainfrom
KorsarOfficial wants to merge 2 commits intoyandex:mainfrom
Conversation
bbeaf75 to
3c19e05
Compare
Author
|
📄 Full analysis report (PDF): 08-perforator-optimizations.pdf Covers complexity analysis, concurrency audit, and verification for all 7 optimizations. |
Contributor
|
I can't agree that using empty context is right in any of these cases. For logging it looses key-value pairs, for cancellation is causes goroutine leaks (incl. in tests). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #95
Semantic analysis
context.TODO()andcontext.Background()are both non-nil, non-cancellable root contexts, but carry different intent signals:context.TODO()context.Background()Only sites where
Background()is the final correct choice are changed. Sites with// TODO: this context should be tied to e.g. Run() durationare intentionally left ascontext.TODO()— the placeholder semantics are correct there.Files changed (6)
agent/collector/pkg/dso/map.goonDeletecallback (no parent context available)agent/collector/pkg/dso/parser/parser.gointernal/binaryprocessor/binaryprocessor.gopkg/kafka/producer/producer.gopkg/profile_event/signal_profile_processor/service.gopkg/s3/http_proxy.goΔ logic = 0. Mechanical substitution only at sites where the intent is unambiguous.