perf(client): exponential backoff in UploadRenderedProfile — ΔT≤5s vs const 5s sleep#98
Open
KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
Open
perf(client): exponential backoff in UploadRenderedProfile — ΔT≤5s vs const 5s sleep#98KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
KorsarOfficial wants to merge 1 commit intoyandex:mainfrom
Conversation
Author
|
📄 Full analysis report (PDF): 08-perforator-optimizations.pdf Covers complexity analysis, concurrency audit, and verification for all 7 optimizations. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #93
Problem
UploadRenderedProfilecontained an unconditionaltime.Sleep(5s)with a// FIXMEcomment. ClickHouseasync_insertmakes the uploaded profile temporarily invisible, but the fixed sleep adds a constant 5-second penalty to every call, including the common case where data is available in < 100 ms.Complexity / latency analysis
Let T_vis = actual ClickHouse visibility latency (random variable).
Sleep(5s)Backoff sequence: 100 ms, 200 ms, 400 ms, 800 ms, 1600 ms, then capped at
remaining.Number of poll attempts: at most ⌈log₂(5000/100)⌉ + 1 = 7.
For T_vis ~ Uniform(0, 200 ms): E[latency] ≈ 100 ms vs 5000 ms — 50× improvement.
Implementation
Invariants:
maxWait = 5s(unchanged worst-case reliability)delayis clamped toremainingbefore the last sleep, preventing overshoot