Skip to content

Post sha1 hulud maintenance#257

Merged
guyca merged 33 commits intomasterfrom
postSha1HuludMaintenance
Dec 29, 2025
Merged

Post sha1 hulud maintenance#257
guyca merged 33 commits intomasterfrom
postSha1HuludMaintenance

Conversation

@guyca
Copy link
Copy Markdown
Collaborator

@guyca guyca commented Dec 9, 2025

Background
Wix employees need to work against Wix's internal NPM registry since the public registry is blocked on Wix network.

Solution:

  • Added .githooks/pre-commit hook that automatically replaces private registry URLs with registry.npmjs.org before each commit
  • Added prepare script to package.json so the hook is auto-configured after yarn install
  • Removed all third party GitHub Actions
  • Locked official GitHub Actions to specific commit SHA
  • Switched to yarn v4
  • Add 14days dependency rule
  • Use npq to install dependencies in CI

Next steps

  • Replace peaceiris/actions-gh-pages@v3 with GitHub's official action to publish to GitHub Pages
  • Use a custom action to publish Jest coverage instead of nolleh/jest-badge-deploy-action@latest

@guyca guyca merged commit 01cb764 into master Dec 29, 2025
2 checks passed
@guyca guyca deleted the postSha1HuludMaintenance branch December 29, 2025 04:35
guyca added a commit that referenced this pull request Mar 3, 2026
Restores the coverage badge that was removed in #257, using only
official GitHub actions.

- Adds `.github/scripts/generate-coverage-badge.js` — a zero-dependency
Node.js script that reads
`packages/react-obsidian/coverage/coverage-summary.json`, extracts line
coverage %, picks a color, and emits a flat shield SVG with the label
`coverage`
- Adds a `coverage` job to `ci.yml` that runs after `build` on push to
master: installs deps, runs `yarn workspace react-obsidian run
test-coverage`, generates the badge SVG, then checks out the `gh-pages`
branch and commits the badge to `badges/coverage-jest coverage.svg`

The existing README badge URL remains valid with no changes required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant