test: cover loading an ESM loader via require() on Node.js 22.12+#89
Merged
Conversation
Node.js enables `require(esm)` by default since 22.12.0, so a `.mjs` loader can now be consumed without the explicit `type: "module"` hint.
Adds fixtures for an ESM loader with a named `pitch` export, an ESM loader exposing `raw = true` alongside `default`, and an ESM loader whose default export is not a function. Tests exercise the `module.pitch` / `module.raw` reads on a real namespace and the `import()` rejection branch in `loadLoader`.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 94.31% 94.31%
=======================================
Files 3 3
Lines 264 264
=======================================
Hits 249 249
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js enables
require(esm)by default since 22.12.0, so a.mjsloader can now be consumed without the explicit
type: "module"hint.