Remove max_workers and alive_nodes_checking_frequency from async replication config#2044
Open
mpartipilo wants to merge 2 commits into
Open
Remove max_workers and alive_nodes_checking_frequency from async replication config#2044mpartipilo wants to merge 2 commits into
mpartipilo wants to merge 2 commits into
Conversation
…ication config Both fields are no-ops on servers >= 1.37.3 (the server silently ignores them), making round-trip assertions unreliable. Remove from the Pydantic create/update models, the read dataclass, both factory methods (Configure/Reconfigure.Replication.async_config), and the parser. Integration and unit tests are updated to use propagation_concurrency and hashtree_height, which do round-trip correctly on all supported server versions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…moval Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_workersandalive_nodes_checking_frequencyfromConfigure.Replication.async_config(),Reconfigure.Replication.async_config(), the Pydantic wire models, the read-side dataclass, and the response parser.propagation_concurrencyandhashtree_heightfor round-trip assertions (fields that do survive the server round-trip).Breaking change
Existing code that passes
max_workers=...oralive_nodes_checking_frequency=...will raise aTypeErrorat runtime after upgrading. No behavioral regression — those values were already being ignored by the server.Related
empty_default_vector_indexbranches.🤖 Generated with Claude Code