refactor(env)!: rename VITE_PLUS_* env vars to VP_* prefix#1166
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| else | ||
| INSTALL_BASH="curl -fsSL https://vite.plus | VITE_PLUS_VERSION=${{ env.VERSION }} bash" | ||
| INSTALL_PS1="\\\$env:VITE_PLUS_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex" | ||
| INSTALL_BASH="curl -fsSL https://vite.plus | VP_VERSION=${{ env.VERSION }} bash" |
Check notice
Code scanning / zizmor
code injection via template expansion Note
| INSTALL_BASH="curl -fsSL https://vite.plus | VITE_PLUS_VERSION=${{ env.VERSION }} bash" | ||
| INSTALL_PS1="\\\$env:VITE_PLUS_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex" | ||
| INSTALL_BASH="curl -fsSL https://vite.plus | VP_VERSION=${{ env.VERSION }} bash" | ||
| INSTALL_PS1="\\\$env:VP_VERSION=\\\"${{ env.VERSION }}\\\"; irm https://vite.plus/ps1 | iex" |
Check notice
Code scanning / zizmor
code injection via template expansion Note
|
@codex review |
jong-kyung
force-pushed
the
refactor/rename-env-vars-vite-plus-to-vp
branch
from
8adb819 to
194e940
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8adb8192e5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jong-kyung
force-pushed
the
refactor/rename-env-vars-vite-plus-to-vp
branch
from
194e940 to
ae89367
Compare
fengmk2
changed the title
|
There's currently a merge conflict with main. If there are no further changes needed, I'll squash the fixup commits and resolve the conflict. |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9057048a3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
fengmk2
left a comment
fengmk2
left a comment
There was a problem hiding this comment.
@jong-kyung good job! Please resolve the conflicts, I will manually verifying and then merge on Monday.
jong-kyung
force-pushed
the
refactor/rename-env-vars-vite-plus-to-vp
branch
from
9057048 to
e5b2f05
Compare
jong-kyung
force-pushed
the
refactor/rename-env-vars-vite-plus-to-vp
branch
from
7ef75ea to
e78b07c
Compare
|
@jong-kyung After I merged the main branch code, CI fails now. Could you help me take a look? |
Sure, I will check It |
|
The CI failure was caused by #1185 ( Updated the test to use the renamed |
Set both VP_VERSION (new) and VITE_PLUS_VERSION (legacy) when invoking the install script, so the action works with vite-plus versions before and after the VP_* env var rename. Ref: voidzero-dev/vite-plus#1166
## Summary - Set both `VP_VERSION` (new) and `VITE_PLUS_VERSION` (legacy) env vars when invoking the vite-plus install script - Ensures the action works with vite-plus versions before and after the `VP_*` env var rename (voidzero-dev/vite-plus#1166) - Includes a TODO comment to remove `VITE_PLUS_VERSION` once old versions are no longer supported ## Test plan - [x] CI passes with current vite-plus release (reads `VITE_PLUS_VERSION`) - [x] After voidzero-dev/vite-plus#1166 merges, verify install still works (reads `VP_VERSION`) 🤖 Generated with [Claude Code](https://claude.ai/claude-code) --------- Signed-off-by: MK (fengmk2) <fengmk2@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2 participants
Summary
Closes #1074
Rename all internal
VITE_PLUS_*environment variables toVP_*prefix to avoid Vite's defaultenvPrefix: "VITE_"from exposing them in bundled applications viaimport.meta.env.get_vite_plus_home()→get_vp_home()to matchdocs/guide/env.md)VITE_LOG,VITE_NODE_DIST_MIRROR,VITE_UPDATE_TASK_TYPES,VITE_GLOBAL_CLI_JS_SCRIPTS_DIR— these use theVITE_prefix (notVITE_PLUS_) and are intentionally keptPrerequisite (merged)
VP_*toDEFAULT_UNTRACKED_ENVso internal vars pass through to child processes without affecting cache keysPlease let me know if I missed anything — I'll fix it.