test(qemu): improve helper and command coverage#710
Open
sachin9058 wants to merge 2 commits into
Open
Conversation
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
✅ Deploy Preview for urunc canceled.
|
Author
|
Hi @cmainas I have added tests for QEMU helper methods and |
Signed-off-by: Sachin Kumar <sachinkumar905846@gmail.com>
sachin9058
force-pushed
the
test/qemu-coverage
branch
from
e3c973b to
93f1085
Compare
Contributor
|
Hello @sachin9058 , please read the contribution guide. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for QEMU helper methods and command construction.
Covered methods:
This increases coverage in
pkg/unikontainers/hypervisorsand improves validation around QEMU command generation.Testing
go test ./pkg/unikontainers/hypervisors -coverCoverage increased from roughly
2.7%to15.2%.