reflect: pass StructOf field slice to reflectlite#5266
Open
cuiweixie wants to merge 1 commit intotinygo-org:releasefrom
Open
reflect: pass StructOf field slice to reflectlite#5266cuiweixie wants to merge 1 commit intotinygo-org:releasefrom
cuiweixie wants to merge 1 commit intotinygo-org:releasefrom
Conversation
StructOf ignored its argument and always called reflectlite.StructOf with an empty field list. Convert []StructField to the reflectlite form so callers' fields are forwarded, consistent with FuncOf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reflect.StructOfpreviously discarded its[]StructFieldargument and always calledreflectlite.StructOfwith an empty slice, so dynamic struct layout never matched the requested fields.Convert each
StructFieldtoreflectlite.StructField(includingTypeviatoRawType), matching howFuncOfforwards its type slices.Note
reflectlite.StructOfremains unimplemented (panics) until that work lands; this change only fixes the forwarding bug at thereflectwrapper layer.Testing
Not run (small wrapper fix).