fix: optimize build process for docsite#378
Open
davidmyriel wants to merge 2 commits intomainfrom
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ovaistariq
reviewed
Apr 8, 2026
| node-version: "22" | ||
| cache: "npm" | ||
|
|
||
| - name: Restore Docusaurus cache |
Contributor
There was a problem hiding this comment.
Is this going to reuse the cache artifacts across different branches? If so, that may pollute the build of one branch with artifacts from another branch
| - name: ESLint | ||
| run: npx eslint . | ||
|
|
||
| build: |
Contributor
There was a problem hiding this comment.
Build has to be dependent on lint passing which is why it was setup as a sequential step
Contributor
|
This needs to be rebased as I have pushed some changes to main. You just need to keep the split of lint and build jobs now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is what I did to the files
.github/workflows/test.yaml— rewritten:docusaurus.config.js— removed the unused @akebifiky/remark-simple-plantuml require and plugin referencepackage.json— uninstalled playwright (unused devDependency) and @akebifiky/remark-simple-plantuml (no PlantUML content in any blog post)Build verified passing locally after all changes.