Skip to content

fix(simplestorage): use lower helper for safe pointer dereferencing #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xe merged 1 commit into from
Jan 26, 2026
+5 −9
Merged

fix(simplestorage): use lower helper for safe pointer dereferencing #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions simplestorage/buckets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,12 @@ func (c *Client) ListBuckets(ctx context.Context, opts ...BucketOption) (*Bucket

for _, b := range resp.Buckets {
result.Buckets = append(result.Buckets, BucketInfo{
Name: *b.Name,
Name: lower(b.Name, ""),
Created: lower(b.CreationDate, time.Time{}),
})
}

if resp.ContinuationToken != nil {
result.NextToken = *resp.ContinuationToken
}
result.NextToken = lower(resp.ContinuationToken, "")

return result, nil
}
Expand Down
8 changes: 3 additions & 5 deletions simplestorage/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,8 @@ func (c *Client) Put(ctx context.Context, obj *Object, opts ...ClientOption) (*O
}

obj.Bucket = o.BucketName
obj.Etag = *resp.ETag
obj.Version = *resp.VersionId
obj.Etag = lower(resp.ETag, "")
obj.Version = lower(resp.VersionId, "")

return obj, nil
}
Expand Down Expand Up @@ -329,9 +329,7 @@ func (c *Client) List(ctx context.Context, opts ...ClientOption) (*ListResult, e
HasMore: lower(resp.IsTruncated, false),
}

if resp.NextContinuationToken != nil {
result.NextToken = *resp.NextContinuationToken
}
result.NextToken = lower(resp.NextContinuationToken, "")

for _, obj := range resp.Contents {
result.Items = append(result.Items, Object{
Expand Down