feat: add rss_bytes memory metric for processes#66
feat: add rss_bytes memory metric for processes#66gtchaos wants to merge 2 commits intotigrisdata:mainfrom
Conversation
Adds the mem_rss_bytes metric from FoundationDB 7.1+ process memory status.
Greptile SummaryThis PR adds Confidence Score: 5/5Safe to merge — only P2 style findings, no correctness or data-integrity issues. Both changes are trivial and correct: the struct field uses the right type and JSON tag, and the metric is emitted inside the existing null guard. The only findings are a one-space alignment gap and a missing test assertion, neither of which affects runtime behavior. No files require special attention. Important Files Changed
|
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Summary
rss_bytesfield toProcessMemorystruct to capture resident memory from FoundationDB 7.1+ process statusmem_rss_bytesmetric in the processes metric groupTest plan
go test ./models/...passesNote
Low Risk
Low risk: adds a new optional
rss_bytesfield to status parsing and exposes it as an additional gauge, without altering existing metric names or collection flow.Overview
Adds resident-set-size memory reporting for processes by extending
ProcessMemorywithRssBytes(mapped from JSONrss_bytes) and emitting a newmem_rss_bytesmetric alongside existing per-process memory gauges.Reviewed by Cursor Bugbot for commit c08d62c. Bugbot is set up for automated code reviews on this repo. Configure here.