add backup range_bytes_written metric#56
Merged
pboros merged 1 commit intotigrisdata:mainfrom May 23, 2025
Merged
Conversation
pboros
approved these changes
May 23, 2025
Collaborator
|
Very cool, thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding the
fdb_cluster_backup_tag_kv_range_bytes_writtenmetric for the backup.This metric makes it possible to track the completeness of a snapshot in progress for a backup.
This is interesting to track how far is a oneshot backup from finishing, and how far is a continuous backup from reaching its restorable state by completing the first snapshot (the continuous backup won't be restorable until the initial snapshot is done).
The snapshot is done when the
fdb_cluster_backup_tag_range_bytes_writtenvalue reachesfdb_cluster_data_total_kv_size_bytes.This makes it possible to clearly track how long it took for a certain backup to reach its initial snapshot/complete.