fix: check for non-nil Locality before use in group_processes#50
Merged
fix: check for non-nil Locality before use in group_processes#50
Conversation
MantasMiksys
reviewed
Apr 2, 2025
| tags["zone"] = process.Locality.ZoneId | ||
| if process.Locality != nil { | ||
| tags["zone"] = process.Locality.ZoneId | ||
| } |
There was a problem hiding this comment.
Shall we maybe set "zone" tag to "unknown" in case Locality info is missing?
Contributor
Author
There was a problem hiding this comment.
I'm not sure what would be better in this case. In other codepath we're setting zone only if locality is available, so to have parity with that behavior just not setting it seems to be better
Collaborator
There was a problem hiding this comment.
Yes, we should set to unknown, otherwise tally will crash if there are time series with different tags.
MantasMiksys
approved these changes
Apr 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locality could be nil in some cases and cause a panic