Added FDB_DEPLOYMENT_NO_K8S env variable#49
Merged
pboros merged 1 commit intotigrisdata:mainfrom Mar 31, 2025
Merged
Conversation
pboros
approved these changes
Mar 31, 2025
Collaborator
|
Thank you for this contribution as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the
FDB_DEPLOYMENT_NO_K8Senv variable for non-k8s deployments where themachineidand theprocessidare more relevant as tags and thefdb_pod_namedoesn't have any meaning.It would be nice to also have all the other additional tags be optionally added only when theyre explicitly set, but for now this is helpful enough.