refactor: externalize FMS host and port via environment variables#197
Merged
Conversation
Remove hardcoded FMS domain and gateway port from the source so they are no longer baked into the public repository. They are now read from the FMS_URL, AUTOWARE_IP, and AUTOWARE_PORT environment variables, which the x2_signage_env_setup Ansible role provisions into autoware.env on production vehicles. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signage_fms_client.pyso internal infrastructure details are no longer baked into the public repository.FMS_URL,AUTOWARE_IP, andAUTOWARE_PORTfrom environment variables instead.x2_signage_env_setupAnsible role that provisions them intoautoware.env.Companion change in
autoware_ecu_system_setupadds the newautoware_pc_portvariable tox2_signage_env_setupand exportsAUTOWARE_PORTtoautoware.env.Test plan
FMS_URL,AUTOWARE_IP,AUTOWARE_PORTexported and confirmed FMS communication works.