config: sqlite + cluster address env overrides for embedded template#10229
Merged
Conversation
stephanos
added a commit
to temporalio/omes
that referenced
this pull request
May 12, 2026
…emplate Now that temporalio/temporal#10229 extends config_template_embedded.yaml with sqlite and CLUSTER_*_ADDRESS support, omes' devserver no longer needs to render its own YAML. The source-build path invokes `temporal-server start --allow-no-auth` with no --config flag (which triggers config.WithEmbedded()) and passes everything via env: - DB / DBNAME / VISIBILITY_DBNAME (sqlite, postgres12*, or mysql8). - FRONTEND/HISTORY/MATCHING/WORKER GRPC_PORT + MEMBERSHIP_PORT. - BIND_ON_IP, NUM_HISTORY_SHARDS, LOG_LEVEL, DYNAMIC_CONFIG_FILE_PATH. - CLUSTER_RPC_ADDRESS / CLUSTER_HTTP_ADDRESS when set. Net: ~190 lines of YAML template gone, plus the text/template dep. Bumps TEMPORAL_SERVER_VERSION to the extend-template branch sha (cad10900) until the changes land on temporal main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stephanos
commented
May 12, 2026
| synchronous: "{{ default "2" (env "SQLITE_SYNCHRONOUS") }}" | ||
| busy_timeout: "{{ default "10000" (env "SQLITE_BUSY_TIMEOUT") }}" | ||
| maxConns: {{ default "1" (env "SQL_VIS_MAX_CONNS") }} | ||
| maxIdleConns: {{ default "1" (env "SQL_VIS_MAX_IDLE_CONNS") }} |
Contributor
Author
There was a problem hiding this comment.
^ taken from temporal/config/development-sqlite-file.yaml
Contributor
There was a problem hiding this comment.
should it follow the format of postgres12/mysql8 in this yaml? for example, for mysql8:
pluginName: "{{ $db }}"
databaseName: "{{ default "temporal" (env "DBNAME") }}"
connectAddr: "{{ default "" (env "MYSQL_SEEDS") }}:{{ default "3306" (env "DB_PORT") }}"
which is also just "pluginName:pluginName" in config/development-mysql8.yaml
stephanos
added a commit
to temporalio/omes
that referenced
this pull request
May 12, 2026
…emplate Now that temporalio/temporal#10229 extends config_template_embedded.yaml with sqlite and CLUSTER_*_ADDRESS support, omes' devserver no longer needs to render its own YAML. The source-build path invokes `temporal-server start --allow-no-auth` with no --config flag (which triggers config.WithEmbedded()) and passes everything via env: - DB / DBNAME / VISIBILITY_DBNAME (sqlite, postgres12*, or mysql8). - FRONTEND/HISTORY/MATCHING/WORKER GRPC_PORT + MEMBERSHIP_PORT. - BIND_ON_IP, NUM_HISTORY_SHARDS, LOG_LEVEL, DYNAMIC_CONFIG_FILE_PATH. - CLUSTER_RPC_ADDRESS / CLUSTER_HTTP_ADDRESS when set. Net: ~190 lines of YAML template gone, plus the text/template dep. Bumps TEMPORAL_SERVER_VERSION to the extend-template branch sha (cad10900) until the changes land on temporal main. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/extend-template
branch
from
cad1090 to
711bc3c
Compare
simvlad
approved these changes
May 14, 2026
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
stephanos
force-pushed
the
stephanos/extend-template
branch
from
711bc3c to
ab383bb
Compare
stephanos
commented
May 14, 2026
Comment on lines
+352
to
+353
| rpcAddress: {{ default (print $temporalClusterAddress ":" $temporalGrpcPort) (env "CLUSTER_RPC_ADDRESS") }} | ||
| httpAddress: {{ default (print $temporalClusterAddress ":" $temporalHTTPPort) (env "CLUSTER_HTTP_ADDRESS") }} |
Contributor
Author
There was a problem hiding this comment.
added this based on feedback from Alex;
so precedence is:
- CLUSTER_RPC_ADDRESS / CLUSTER_HTTP_ADDRESS (the new overrides)
- TEMPORAL_BROADCAST_ADDRESS + FRONTEND_GRPC_PORT / FRONTEND_HTTP_PORT
- BIND_ON_IP + FRONTEND_GRPC_PORT / FRONTEND_HTTP_PORT
- 127.0.0.1 + FRONTEND_GRPC_PORT / FRONTEND_HTTP_PORT
Contributor
Author
|
I'll merge, but if there's a change request before we cut the next OSS release I'd be happy to adjust it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extend
common/config/config_template_embedded.yamlwith(1) SQLite option
(2) option to override
rpcAddressand/orhttpAddressWhy
https://github.com/temporalio/omes needs to be able to start a Temporal server with sqlite and custom addresses.
See temporalio/omes#348