Correct the format of Regional Endpoints in the list of Regions#4554
Open
lukeknep wants to merge 2 commits into
Open
Correct the format of Regional Endpoints in the list of Regions#4554lukeknep wants to merge 2 commits into
lukeknep wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📖 Docs PR preview links
|
Contributor
daniel-goldstein
left a comment
daniel-goldstein
left a comment
There was a problem hiding this comment.
Looks mostly good but I don't think we can actually change the HA sections since we still use the old endpoint in CNAMEs
| ## Configure private DNS for Namespaces with High Availability | ||
|
|
||
| For Namespaces with [High Availability features](/cloud/high-availability), you need to override DNS for `region.tmprl.cloud` so each region resolves to the local VPC Endpoint, and you need to ensure Workers can reach whichever region is active. Failover is transparent to clients only when this is set up correctly. | ||
| For Namespaces with [High Availability features](/cloud/high-availability), you need to override DNS for `region.tmprl.io` so each region resolves to the local VPC Endpoint, and you need to ensure Workers can reach whichever region is active. Failover is transparent to clients only when this is set up correctly. |
Contributor
There was a problem hiding this comment.
This should still be region.tmprl.cloud.
|
|
||
| :::note Update outdated regional endpoints | ||
|
|
||
| The older regional endpoint format ending in `region.tmprl.cloud` (for example, `aws-us-east-1.region.tmprl.cloud`) is outdated. Update any Clients, Workers, and private DNS records to the current format ending in `api.temporal.io` (for example, `us-east-1.aws.api.temporal.io:7233`) to ensure uninterrupted access to your Temporal Cloud Namespaces. |
Contributor
There was a problem hiding this comment.
I this it's unlikely people are using region.tmprl.cloud in their clients directly, as we don't support certs for those domains. Maybe someone could use it in combination with a server_name override, but that feels unlikely.
|
|
||
| - When working with Multi-region Namespaces, your CNAME may change. | ||
| For example, it may switch from aws-us-west-1.region.tmprl.cloud to aws-us-east-1.region.tmprl.cloud. | ||
| For example, it may switch from us-west-1.aws.api.temporal.io to us-east-1.aws.api.temporal.io. |
Contributor
There was a problem hiding this comment.
it looks like this is not the current behavior though with HA namespaces?
|
|
||
| - The Namespace DNS record (`<ns>.<account>.tmprl.cloud`) is a CNAME. | ||
| - It points to the active region's regional record (`<provider>-<region>.region.tmprl.cloud`). | ||
| - It points to the active region's regional record (`<region>.<provider>.api.temporal.io`). |
Contributor
There was a problem hiding this comment.
Same comment for this whole page, I don't think we're CNAME'ing HA Namespace Endpoints to api.temporal.io domains
Contributor
There was a problem hiding this comment.
daniel@Daniels-MacBook-Pro saas-components % dig daniel.a2dd6.tmprl.cloud
; <<>> DiG 9.10.6 <<>> daniel.a2dd6.tmprl.cloud
;; global options: +cmd
;; Got answer:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 13742
;; flags: qr rd ra; QUERY: 1, ANSWER: 7, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 4096
;; QUESTION SECTION:
;daniel.a2dd6.tmprl.cloud. IN A
;; ANSWER SECTION:
daniel.a2dd6.tmprl.cloud. 15 IN CNAME aws-us-east-1.region.tmprl.cloud.
aws-us-east-1.region.tmprl.cloud. 60 IN A 54.86.97.16
aws-us-east-1.region.tmprl.cloud. 60 IN A 35.170.125.250
aws-us-east-1.region.tmprl.cloud. 60 IN A 34.195.80.228
aws-us-east-1.region.tmprl.cloud. 60 IN A 100.28.203.93
aws-us-east-1.region.tmprl.cloud. 60 IN A 52.86.32.76
aws-us-east-1.region.tmprl.cloud. 60 IN A 34.199.152.251
| ["eu-west-2","com.amazonaws.vpce.eu-west-2.vpce-svc-0ac7f9f07e7fb5695"], | ||
| ["sa-east-1","com.amazonaws.vpce.sa-east-1.vpce-svc-0ca67a102f3ce525a"], | ||
| [ "us-east-1","com.amazonaws.vpce.us-east-1.vpce-svc-0822256b6575ea37f"], | ||
| [ "us-east-2","com.amazonaws.vpce.us-east-2.vpce-svc-01b8dccfc6660d9d4"], |
Contributor
There was a problem hiding this comment.
nit: weird spaces here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
api.temporal.io, which is already reflected in our UI / API / CLI.tmprl.cloud), including the list of Regions & their regional endpoints. While these still "work" today, they are subject to change without notice and should not be used in Users' code....region.tmprl.cloudin the docs.Notes to Reviewers
┆Attachments: EDU-6342 Correct the format of Regional Endpoints in the list of Regions