Skip to content

fix: disable mousewheel directive when zoom is disabled#541

Open
alesbrelih wants to merge 1 commit intoswimlane:masterfrom
alesbrelih:fix/fe/scrolling-when-zoom-disabled
Open

fix: disable mousewheel directive when zoom is disabled#541
alesbrelih wants to merge 1 commit intoswimlane:masterfrom
alesbrelih:fix/fe/scrolling-when-zoom-disabled

Conversation

@alesbrelih
Copy link
Copy Markdown

This allows to normally scroll through page when zoom is disabled.

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

When zoom is disabled you can't use mouse wheel to scroll to the bottom of page if mouse is over the ngx-graph component.

What is the new behavior?

If zoom is disabled you can normally use your mouse wheel to scroll.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

This allows to normally scroll through page when zoom is disabled.
@Ramxnchv
Copy link
Copy Markdown

Ramxnchv commented Jan 30, 2025

Hi @marjan-georgiev, can we get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants