Add Package.resolved and dependabot.yml#147
Add Package.resolved and dependabot.yml#147incertum wants to merge 2 commits intoswift-server:mainfrom incertum:add-resolved-packages-dependabot
Package.resolved and dependabot.yml#147Conversation
Signed-off-by: Melissa Kilby <mkilby@apple.com>
Signed-off-by: Melissa Kilby <mkilby@apple.com>
FranzBusch
left a comment
There was a problem hiding this comment.
I don't think that we should go ahead with this PR. The recommendation right now is to not commit the resolved file in libraries since the file has no impact on users of the package. Furthermore, libraries should avoid bumping the min versions unless there is a need for it e.g. new APIs available in a dependency.
There is a bigger discussion ongoing around this. Let's move this PR to draft state until there are new features or a new decision / outcome in this regard. |
|
Yeah, it is not useful to have a Package.resolved in libraries. Package.resolved isn't a real lock file; it doesn't matter at all in libraries either since consumer will just resolve anyway. |
ACK. Hoping this changes in the future and there will be new features allowing honoring a library’s real lock file (aligning with security best practices :)). |
ktoso
left a comment
There was a problem hiding this comment.
I don't think we should do this in libraries
Add
Package.resolvedanddependabot.yml