Fix JVM crash when accessing array-backed RecordId keys#141
Merged
emmanuel-keller merged 1 commit intomainfrom Apr 28, 2026
Merged
Fix JVM crash when accessing array-backed RecordId keys#141emmanuel-keller merged 1 commit intomainfrom
emmanuel-keller merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
kearfy
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #140.
This fixes a JVM crash when accessing array- or object-backed
RecordIdkeys throughRecordId.getId(). The Java native declarations forId.getArray(...)andId.getObject(...)expected Java objects, while the JNI implementation returns raw native pointers (jlong). The JVM could then interpret a native pointer as an object reference, causing a SIGSEGV when calling methods likelen()orget(0).Changes
Idnative array/object accessors to returnlongnative pointers.Array/Objecton the Java side, matching the existingValueaccessor pattern.RecordIdkeys from query results.RecordIdkey accessors.Testing
./gradlew test --tests com.surrealdb.ValueTypesTests.recordIdArrayKeyAccessorsFromQuery --tests com.surrealdb.TypeTests.testRecordIdWithArrayKey --tests com.surrealdb.TypeTests.testRecordIdWithObjectKey git diff --check