Skip to content

fix(ollama): update return type of latencyMs metric for ollama model provider#2236

Merged
mkmeral merged 1 commit into
strands-agents:mainfrom
paliwalvimal:fix/ollama-latency-metric
May 12, 2026
Merged

fix(ollama): update return type of latencyMs metric for ollama model provider#2236
mkmeral merged 1 commit into
strands-agents:mainfrom
paliwalvimal:fix/ollama-latency-metric

Conversation

@paliwalvimal
Copy link
Copy Markdown

@paliwalvimal paliwalvimal commented May 1, 2026

Description

update return type of latencyMs metric for ollama model provider to return int value instead of float as per the requirement:

latencyMs: Required[int]

Related Issues

#2235

Documentation PR

N/A

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@paliwalvimal paliwalvimal marked this pull request as ready for review May 1, 2026 15:34
@paliwalvimal paliwalvimal deployed to manual-approval May 1, 2026 15:34 — with GitHub Actions Active
@mkmeral mkmeral enabled auto-merge (squash) May 12, 2026 15:47
@github-actions
Copy link
Copy Markdown

Assessment: Approve

Clean, minimal bugfix that correctly aligns the Ollama provider's latencyMs output with the Metrics TypedDict contract (latencyMs: Required[int]). The int() cast is the right approach, tests are updated consistently, and the change is consistent with how other model providers handle this field (they already return integer values).

No issues found — good to go. 👍

@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mkmeral mkmeral merged commit b1a3f03 into strands-agents:main May 12, 2026
27 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants