feat: add per-alias autotag toggle + general api/app support for per-alias autotag#6694
Open
notsafeforgit wants to merge 9 commits intostashapp:developfrom
Open
feat: add per-alias autotag toggle + general api/app support for per-alias autotag#6694notsafeforgit wants to merge 9 commits intostashapp:developfrom
notsafeforgit wants to merge 9 commits intostashapp:developfrom
Conversation
notsafeforgit
force-pushed
the
feat/autotag-aliases
branch
19 times, most recently
from
83c44e3 to
30d77f1
Compare
notsafeforgit
commented
Mar 18, 2026
| func toPerformerAliases(aliases []string) []models.PerformerAlias { | ||
| var res []models.PerformerAlias | ||
| for _, a := range aliases { | ||
| res = append(res, models.PerformerAlias{Alias: a, IgnoreAutoTag: true}) |
Contributor
Author
There was a problem hiding this comment.
All current performers don't support autotagging aliases, so backups should be imported with autotag ignored for aliases set to true.
notsafeforgit
force-pushed
the
feat/autotag-aliases
branch
7 times, most recently
from
eab0eb8 to
76da2d8
Compare
Contributor
Author
|
Just wanted to comment that I'm now running a custom fork of stash with this change and have extensively tested this PR and it appears to work great. I have autotag enabled for many aliases for many performers and have seen no issues. |
Add DB support and graphQL API support to track alias matching being on or off per alias. By default, new aliases (especially from scrapers) are set to be ignored for auto-tagging. The UI toggle has been updated to reflect an 'Auto tag' boolean checkbox that allows users to opt-in specific aliases.
This fixes a bug where clicking Save in the performer edit panel did nothing. The yup schema requires the 'aliases' field to be present for casting, but it was being destructured out before being passed to `schema.cast()`, causing a validation crash inside Formik's onSubmit handler that silently aborted the save action.
…p panic Modified NormalizeAliases to return an initialized empty slice instead of nil when aliases are empty. This ensures the aliases relationship is marked as 'loaded', preventing a panic in ValidateCreate. Added a corresponding unit test to verify creation with empty or filtered aliases.
notsafeforgit
force-pushed
the
feat/autotag-aliases
branch
from
cf13b5d to
08b7a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add DB support and graphQL API support to track alias matching for a performer being on or off on a per-alias basis. By default, new aliases (especially from scrapers) are set to be ignored for auto-tagging. The UI toggle has been updated to reflect an 'Auto tag' boolean checkbox that allows users to opt-in specific aliases.
Attached is a screenshot of the new alias list UI with autotag toggles: