[Feature] Add `Frames` to VideoFile. UI and Graphql by bob12224 · Pull Request #6671 · stashapp/stash

bob12224 · 2026-03-12T07:49:41Z

name: Feature Addition
about: Add a feature to this project!
title: "[Feature] Add Frames to VideoFile. UI and Graphql"
labels: enhancement
assignees: 'WithoutPants, bnkai, Leopere'

Scope

Grabbing the Frame Count from the FFProbe (which is already done on all Video Files) and saving it into DB.
Then making the value available via GraphQl and in the Scene page, under File Info.

Closes/Fixes Issues

Fixes Add Frames to all video files #6230

Other testing QA Notes

I have a full local dev server running. I have tested the migrations and manually adding files + scan. Frames is correctly calculated and saved into the DB. It is available in graphql, and I also added it to the File Info Screen (for Scene).

NOTE: I chose to not add this as a filter or sorting option. My needs are to read the value, so if anyone wants to filter/sort on Frames, I can add it.

u

bob12224 · 2026-03-12T23:09:50Z

docs/DEVELOPMENT.md

 #### Ubuntu

 1. Install dependencies: `sudo apt-get install golang git gcc nodejs ffmpeg -y`
+    * To install `pnpm`: `npm install -g pnpm`


I can remove this. Added it because the Pre-requisites kinda hides this for a new dev

bob12224 · 2026-03-12T23:11:33Z

pkg/ffmpeg/ffprobe.go

 		"-show_format",
 		"-show_streams",
 		"-show_error",
+		"-count_frames",


There might be bigger changes required by this change. Now that we get the FrameCount by default, might be able to delete GetReadFrameCount function.

I leave larger refactoring to the maintainer to suggest

feederbox826 · 2026-03-16T23:22:12Z

Your PR contains commits by a different user. Please verify that the commits are properly attributed to the authors you want

Gykes · 2026-03-17T00:42:25Z

Deferred till next release. Will review once this release closes out.

bob12224 · 2026-03-17T03:20:57Z

Your PR contains commits by a different user. Please verify that the commits are properly attributed to the authors you want

I have rebased and renamed the author of those commits. Thanks for the catch

feederbox826

Not sure how useful this is to a broader audience, the ffprobe on post-migration is quite worrying. Frames can be esimated with duration * framerate and unless your entire library is restricted in duration, filters and sorting give you ????

feederbox826 · 2026-03-18T02:25:14Z

pkg/models/jsonschema/scene.go

 	Width      int           `json:"width"`
 	Height     int           `json:"height"`
 	Framerate  string        `json:"framerate"`
+	Frames     int           `json:"frame"`


inconsistent name?

feederbox826 · 2026-03-18T02:28:08Z

pkg/sqlite/setup_test.go

 			VideoCodec: getFileStringValue(i, "videoCodec"),
 			AudioCodec: getFileStringValue(i, "audioCodec"),
 			FrameRate:  getFileDuration(i) * 2,
+			Frames:     int64(getFileDuration(i)) * 3,


shouldn't this be duration * frameRate?

feederbox826 · 2026-03-18T02:30:54Z

pkg/sqlite/migrations/86_postmigrate.go

+				path := filepath.Join(dir, basename)
+
+				frames, err := m.ffprobe.GetReadFrameCount(path)
+				if err != nil || frames <= 0 {


is this the equality sign you want?

IF (err != nil) || (frames <= 0) -> do not update row
IF (there was an error) OR (frames is not a valid number) -> do not update row

if frames is less than or equal to 0 that is considered an invalid number.
I could change it to <, but 0 frame video file seems invalid...

feederbox826 · 2026-03-18T02:33:34Z

pkg/sqlite/migrations/85_video_file_frames.up.sql

@@ -0,0 +1 @@
+ALTER TABLE video_files ADD COLUMN frames INTEGER NOT NULL DEFAULT 0;


why not DEFAULT NULL and check for NULL in your postmigration?

updated to use NULL here and in the postmigrate

bob12224 · 2026-03-18T18:24:26Z

Not sure how useful this is to a broader audience, the ffprobe on post-migration is quite worrying. Frames can be estimated with duration * framerate and unless your entire library is restricted in duration, filters and sorting give you ????

@feederbox826 While frames can be estimated, it is an estimate that can be incorrect (hence the PR). Frames might not be useful to the average user, but it it is critical for anyone using video editors that require frame accuracy (plugin developers). I am using OTIO and it requires accurate frames.

An alternative was described in the original ticket, but it seemed much more ambitious

bob12224 · 2026-03-18T18:28:14Z

pkg/sqlite/migrations/86_postmigrate.go

+		Count int `db:"count"`
+	}{0}
+
+	if err := m.db.Get(&result, "SELECT COUNT(*) AS count FROM `video_files` WHERE `frames` IS NULL"); err != nil {


@feederbox826 I could delete this 86_postmigrate.go and if people wanted to back fill their frames data, they could re-generate it from the tasks menu?

feederbox826 · 2026-03-18T18:58:40Z

An alternative was described in the original ticket, but it seemed much more ambitious

since then, custom filed support has landed for scenes specifically #6584 #6601

would this not address your usecase?

bob12224 · 2026-03-18T19:04:35Z

An alternative was described in the original ticket, but it seemed much more ambitious

since then, custom filed support has landed for scenes specifically #6584 #6601

would this not address your usecase?

custom fields would address my issue.

I hesitate to close this PR though, if anyone else wants to frames per video, they would need to download a plugin and frames would not be available in the file info tab

Gykes · 2026-03-27T05:40:06Z

With only a general code check and not too much research my initial thoughts are this:

So it looks to me like, since this runs on every file, it will significantly increase scan times on every file. If i'm not mistaken -count_frames forces ffprobe to scan every single frame no matter what. Would probably be better to make this optional so that users don't all get wrecked with vastly increased scan times because a handful of people want this.

Same as above for the post migration, it will scan every file to generate this data being REALLY slow and people will just be loading on startup as the migration runs. Depending on how large a users library is this could take a while. I think this should be optional if users want to enable it via generate.

Fb's point of custom fields is valid imo. Not too many users will get a usecase from this and would be pretty heavy. Since the userbase is pretty small would a plugin not be valid here?

feederbox826 · 2026-03-27T05:54:05Z

I hesitate to close this PR though, if anyone else wants to frames per video, they would need to download a plugin and frames would not be available in the file info tab

with stuff like HashTheStash that adds additional hashes and with the new fileinfo react hook, it's totally possible to just add frames in as a custom field.

I really don't see a very broad scope and usecase for your average user especially at the cost of the post-migration, moreso if users have offline or disconnected media

Merge pull request #1 from stashapp/develop

1314938

u

bob12224 commented Mar 12, 2026

View reviewed changes

Gykes self-assigned this Mar 17, 2026

bob12224 force-pushed the frames branch 2 times, most recently from 1e248a7 to 00d808c Compare March 17, 2026 03:15

bob12224 added 3 commits March 16, 2026 20:19

(feat) Adding frames for all video files, adding to the UI and graphql.

88255ce

PR linting fixes

16f31ba

PR Unit test fixes

39c5a98

bob12224 force-pushed the frames branch from 00d808c to 39c5a98 Compare March 17, 2026 03:20

Gykes added the deferred Good feature that can be looked at for a later release. label Mar 17, 2026

feederbox826 requested changes Mar 18, 2026

View reviewed changes

PR Fixes

b679c6d

bob12224 commented Mar 18, 2026

View reviewed changes

bob12224 added 2 commits March 18, 2026 11:52

Merge branch 'stashapp:develop' into frames

7f9fde3

Updating migration to 86

832d190

Gykes added the plugin idea Candidate for plugin. Does not necessarily mean won't fix. label Mar 27, 2026

		@@ -0,0 +1 @@
		ALTER TABLE video_files ADD COLUMN frames INTEGER NOT NULL DEFAULT 0; No newline at end of file

Uh oh!

Conversation

bob12224 commented Mar 12, 2026

Scope

Closes/Fixes Issues

Other testing QA Notes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feederbox826 commented Mar 16, 2026

Uh oh!

Gykes commented Mar 17, 2026

Uh oh!

bob12224 commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

feederbox826 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bob12224 commented Mar 18, 2026

Uh oh!

bob12224 Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

feederbox826 commented Mar 18, 2026

Uh oh!

bob12224 commented Mar 18, 2026

Uh oh!

Gykes commented Mar 27, 2026

Uh oh!

feederbox826 commented Mar 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bob12224 commented Mar 17, 2026 •

edited

Loading

bob12224 Mar 18, 2026 •

edited

Loading