add image scraping to built-in Auto-Tag scraper#6650
add image scraping to built-in Auto-Tag scraper#6650spaceyuck wants to merge 2 commits intostashapp:developfrom
Conversation
There was a problem hiding this comment.
This looks reasonable as a gap-fill since scenes and galleries already support it. I believe that the practical value is narrower for images. Image filenames tend to be generic and images in galleries would typically inherit metadata at the gallery level rather than being individually auto-tagged. The main benefit is standalone images in well-organized folder structures.
it was already available for galleries and scenes, images just seem to have slipped through
abfebf6 to
85460b4
Compare
Definitely, it's a some metadata is better than no metadata kind of deal. I've made some changes. |
There was a problem hiding this comment.
After pulling it down I don't see the option in Settings -> Tasks -> Auto Tag to enable and disable images.
When I told it to auto tag I did see this in the logs: Auto-tagging images... so it appears to be trying to work just there is no way to enable/disable. I know your PR title says that it gets added to the image details but if you run autotag app wide is still attempts to autotag images.
I'm not sure what you mean, but there are only toggles to select what to tag with (tag, performers, studios), not what to tag (image, scene, gallery)
The Bulk Auto-Tag mechanism from Settings Tasks and from Tags / Performers / Studios already supported images before this, and is run out of I think task_autotag.go. This change should not have any effect on that whole logic. This change is to add the equivalent of the "imageByFragment" scrape operation to the builtin Auto-Tag scraper, so that it would show up in the image details scrape menu, and a (hopefully) future image Tagger list view. I've reworded the PR title and description a bit to make it more clear what this actually does. |
|
You're absolutely, right. I think I was extremely tired when I wrote that as I cant even remember what I was trying to get across lol. Will re-review in the next few days |
| path := image.Path | ||
| if path == "" { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
The empty path check should probs be outside the transaction. No point opening a read transaction just to find out the path is empty. You can reference viaGallery above to see what I mean.
The bulk Auto-Tag operations already supported images, but the built-in Auto-Tag scraper did not support them, therefore the option was missing in the image details scrape menu. It was already available for galleries and scenes, images just seem to have just slipped through. Seems to work fine, not sure if there was a reason why this wasn't implemented already.
Hopefully, this can be a first step in making Images a first class citizen in terms of scraping UI. But one step at a time.