Open
Conversation
Gykes
requested changes
Mar 7, 2026
pkg/sqlite/tag_filter.go
Outdated
Comment on lines
+187
to
+188
| addJoinTable: func(f *filterBuilder, joinType joinType) { | ||
| tagRepository.aliases.leftJoin(f, "", "tags.id") |
Collaborator
There was a problem hiding this comment.
joinType is accepted but ignored. Looks like it's always using leftJoin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces left joins with inner joins where it makes sense to do so (ie where we are checking for the presence of related objects). Left joins are used only where we need to check for null related values.
Also removed the use of
trimfrom the stash ids criterion where clauses.While the unit tests pass, I will likely defer this until the following release to allow time for potential breakages to appear.
No actual performance comparison testing has been performed yet.
Related to #6455