Refactor map initialization in DefaultUriBuilderFactory to use CollectionUtils#36763
Open
shenjianeng wants to merge 1 commit into
Open
Refactor map initialization in DefaultUriBuilderFactory to use CollectionUtils#36763shenjianeng wants to merge 1 commit into
shenjianeng wants to merge 1 commit into
Conversation
Signed-off-by: shenjianeng <ishenjianeng@qq.com>
spring-projects-issues
added
the
status: waiting-for-triage
DhruvTheDev1
approved these changes
May 8, 2026
Contributor
DhruvTheDev1
left a comment
DhruvTheDev1
left a comment
There was a problem hiding this comment.
Solid micro-optimisation!
Map<String, Object> map = CollectionUtils.newHashMap(defaultUriVariables.size() + uriVars.size());Ensures the map is pre-sized to handle the combined size of defaultUriVariables and uriVars without needing to rehash/resize. Logic remains consistent with the existing URI behaviour.
rstoyanchev
added
in: web
rstoyanchev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.