Skip to content

fix: move AlbHealthCheckLayer outside CoffeeShop to fix /ping routing#191

Merged
kstich merged 1 commit into
smithy-lang:mainfrom
PeterUlb:fix/ping-health-check
May 13, 2026
Merged

fix: move AlbHealthCheckLayer outside CoffeeShop to fix /ping routing#191
kstich merged 1 commit into
smithy-lang:mainfrom
PeterUlb:fix/ping-health-check

Conversation

@PeterUlb
Copy link
Copy Markdown
Contributor

Background

  • The smithy-rust-quickstart template places the AlbHealthCheckLayer inside the CoffeeShopConfig builder. At that level, Smithy's router rejects /ping as an unknown operation and returns a 404. This PR moves the health check layer outside the CoffeeShop service so it intercepts requests before routing, and /ping correctly returns 200.
  • No new example was added.

Testing

  • Ran the quickstart server locally and confirmed /ping returns 200 instead of 404.
  • No integration test was added.
  • N/A - no new example was added.

Links

  • N/A

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.

@kstich kstich merged commit 6d91c7e into smithy-lang:main May 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants