Open
Conversation
added 2 commits
February 16, 2026 15:45
sarahmish
reviewed
Mar 12, 2026
Contributor
sarahmish
left a comment
sarahmish
left a comment
There was a problem hiding this comment.
According to the issue you initially were calling it Cluster2Float and Float2Cluster. Is there a reason you changed it to Cluster2Scalar and Scalar2Cluster?
Comment on lines
+10
to
+11
| "sigllm.primitives.transformation.Cluster2Scalar", | ||
| "sigllm.primitives.transformation.Cluster2Scalar", |
Contributor
There was a problem hiding this comment.
What is the purpose of the second Clustr2Scalar? Note that the jupyter notebook in the PR seems to use an older version of the pipeline with only one Clustr2Scalar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #56
Added K-Means binning as a way to pre-process floats into scalars.