build: Unify bindings and glue code flags with cc-rs#734
Open
jschwe wants to merge 8 commits into
Open
Conversation
CLANGFLAGS was only applied to bindgen. cc-rs is not documented to use it, and SM also doesn't reference it. In servo I also couldn't see us setting this variable. This is a preperation for unifying our common build flags across cc-rs, SM build and bindgen. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Use the cc-rs builder to unify the bindings and glue flags. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
build-rs-cc-rs-unification2
branch
from
dde2c63 to
84ba7a9
Compare
and a bit of refactoring for target.include_paths Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
force-pushed
the
build-rs-cc-rs-unification2
branch
from
bfda141 to
bc88745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #732.
Refactor cc_flags to get_common_cc, which returns a cc builder. Any bindgen specific flags are moved to build_bindings.
Removed the explicit
O0override, this will be configured by cc-rs based on opt-level (for the glue code, and ignored by bindgen).Testing: Describe how this pull request is tested or why it doesn't require tests
Servo PR: Link to a companion pull request in the Servo repository. Remove this line if there is no companion PR.