docs: add FIDO2 / security-key MFA implementation plan (#138)#139
Merged
Conversation
Document the analysis and roadmap for supporting physical FIDO2 security keys (YubiKey) as a second factor. Includes the captured fsaChallenge response shape, why fastlane's spaceship offers no reference to port from, the prerequisite of capturing Apple's verification endpoint from a browser session, and two viable client-side approaches (libfido2 bridge vs. pure-Swift CTAP2 over IOHIDManager) for a future contributor with the hardware to test.
Contributor
There was a problem hiding this comment.
This documentation-only PR provides a comprehensive implementation roadmap for FIDO2/security key MFA support. The document is well-structured, technically accurate, and contains no blocking issues. The implementation plan appropriately documents the technical challenges, provides clear guidance with code examples, and outlines testing strategies. No defects found that would prevent merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fsaChallengepayload (essentially WebAuthnPublicKeyCredentialRequestOptions) that xcodeinstall does not currently decode.spaceshipdoes not implement this — full-repo search returns zero hits forfsaChallenge,FIDO,webauthn, etc. — so there is no Ruby reference to port.AuthenticationServicesframework is unsuitable for a CLI binary (needs a GUI presentation anchor and Associated Domains matchingapple.com).libfido2(~150–300 lines of Swift glue,brew install libfido2prerequisite) or pure-Swift CTAP2 overIOHIDManager(~800–1200 lines, zero install burden).Test plan
docs/fido2-mfa-plan.mdrenders correctly on GitHub.