fix: filter aliased folder types in SDRMetadataAdapter#1222
Merged
Conversation
EmailTemplateFolder (aliasFor: emailfolder) shares directoryName 'email' with EmailTemplate, causing it to overwrite EmailTemplate in the metadataPerDir map and silently drop email template files. Extend getOrCreateCache() to also exclude types whose aliasFor points to a known folder type, preventing alias types from polluting the metadata output.
13f27a1 to
008f53c
Compare
|
Published under $ sf plugins install sf-git-merge-driver@dev-1222 |
|
Shipped in release $ sf plugins install sfdx-git-delta@latest-rc
# Or
$ sf plugins install sfdx-git-delta@v6.32.3💡 Enjoying sfdx-git-delta? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain your changes
EmailTemplateFolder(id:emailtemplatefolder,aliasFor: "emailfolder") sharesdirectoryName: "email"withEmailTemplate. It passed the folder-type filter ingetOrCreateCache()because no type referencesemailtemplatefolderas afolderType. It overwroteEmailTemplatein themetadataPerDirmap, causing email files to silently resolve to the wrong type and be dropped.Extend
getOrCreateCache()to also exclude types whosealiasForpoints to a known folder type. The fix is generic — not hardcoded toemailtemplatefolder— so future SDR types withaliasForpointing to folder types will be handled automatically.Does this close any currently open issues?
Any particular element that can be tested locally
Any other comments
Currently
emailtemplatefolderis the only SDR type withaliasFor, but the fix handles any future alias types generically.