Skip to content

fix: parent file inclusion for Decomposed type#1002

Merged
scolladon merged 6 commits intomainfrom
fix/decomposed-sharing-rules
Feb 4, 2025
Merged

fix: parent file inclusion for Decomposed type#1002
scolladon merged 6 commits intomainfrom
fix/decomposed-sharing-rules

Conversation

@scolladon
Copy link
Copy Markdown
Owner

Explain your changes


Now the code ensure the parent type file is included in the output folder
It just copy the parent file but do not include the parent type in the package.xml

Does this close any currently open issues?


closes #1000

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon scolladon requested a review from mehdicherf as a code owner January 31, 2025 18:29
@scolladon
Copy link
Copy Markdown
Owner Author

Hi @eheyhuron!

Could you test on your laptop and help us validate this PR please ?
You can follow those steps to easily do it locally

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (67071e2) to head (91afa4a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1002   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines         1028      1036    +8     
  Branches       112       113    +1     
=========================================
+ Hits          1028      1036    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scolladon scolladon force-pushed the fix/decomposed-sharing-rules branch from ac66d2f to 87747de Compare February 1, 2025 12:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 1, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

mehdicherf
mehdicherf previously approved these changes Feb 3, 2025
@scolladon scolladon force-pushed the fix/decomposed-sharing-rules branch from 7dc7f09 to 88dab61 Compare February 3, 2025 09:47
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

@scolladon
Copy link
Copy Markdown
Owner Author

Hi @eheyhuron!

Could you test on your laptop and help us validate this PR please ? You can follow those steps to easily do it locally

It would be greatly appreciated 😄
I'll wait till tomorrow before merging

@qlty-cloud-legacy
Copy link
Copy Markdown

Code Climate has analyzed commit 91afa4a and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

@scolladon scolladon merged commit e5f2a27 into main Feb 4, 2025
19 of 21 checks passed
@scolladon scolladon deleted the fix/decomposed-sharing-rules branch February 4, 2025 08:54
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025

Published under dev-1002 npm channel.

$ sf plugins install sfdx-git-delta@dev-1002

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025

Shipped in release v6.3.0.
Version v6.3.0 will be assigned to the latest npm channel soon
Install it using either v6.3.0 or the latest-rc npm channel

$ sf plugins install sfdx-git-delta@latest-rc
# Or
$ sf plugins install sfdx-git-delta@v6.3.0

💡 Enjoying sfdx-git-delta?
Your contribution helps us provide fast support 🚀 and high quality features 🔥
Become a sponsor 💙
Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SGD Missing Dependent File on Decomposed Sharing Rule

2 participants