fix: simplify @log decorator and defer debug serialization

src/commands/git/merge/driver/run.ts

@@ -10,7 +10,7 @@ import { PLUGIN_NAME } from '../../../../constant/pluginConstant.js'
 import { MergeDriver } from '../../../../driver/MergeDriver.js'
 import type { MergeConfig } from '../../../../types/conflictTypes.js'
 import { log } from '../../../../utils/LoggingDecorator.js'
-import { Logger } from '../../../../utils/LoggingService.js'
+import { Logger, lazy } from '../../../../utils/LoggingService.js'
 
 Messages.importMessagesDirectoryFromMetaUrl(import.meta.url)
 const messages = Messages.loadMessages(PLUGIN_NAME, 'run')
@@ -84,8 +84,8 @@ export default class Run extends SfCommand<void> {
       otherConflictTag: flags['other-conflict-tag'],
     }
 
-    Logger.debug(`flags: ${JSON.stringify(flags)}`)
-    Logger.debug(`config: ${JSON.stringify(config)}`)
+    Logger.debug(lazy`flags: ${() => JSON.stringify(flags)}`)
+    Logger.debug(lazy`config: ${() => JSON.stringify(config)}`)
 
     const mergeDriver = new MergeDriver(config)
     const hasConflict = await mergeDriver.mergeFiles(

src/utils/LoggingDecorator.ts

@@ -1,42 +1,6 @@
 /** biome-ignore-all lint/suspicious/noExplicitAny: it is dynamic by definition */
 import { Logger, lazy } from './LoggingService.js'
 
-export function stringify(value: unknown): string {
-  if (hasCustomToString(value)) {
-    return value.toString()
-  }
-  return JSON.stringify(value, replacer)
-}
-
-function replacer(_key: string, value: unknown): unknown {
-  if (value instanceof Map) {
-    return Array.from(value.entries())
-  }
-  if (value instanceof Set) {
-    return Array.from(value)
-  }
-  return value
-}
-
-export function hasCustomToString(
-  obj: unknown
-): obj is { toString: () => string } {
-  if (obj === null || typeof obj !== 'object') return false
-
-  const toStringFn = (obj as any).toString
-  if (typeof toStringFn !== 'function') return false
-
-  if (Object.hasOwn(obj, 'toString')) {
-    return toStringFn !== Object.prototype.toString
-  }
-  const proto = Object.getPrototypeOf(obj)
-  const protoToString = proto.toString
-  return (
-    typeof protoToString === 'function' &&
-    protoToString !== Object.prototype.toString
-  )
-}
-
 export function log(
   target: any,
   propertyKey: string,
@@ -46,16 +10,10 @@ export function log(
 
   descriptor.value = function (...args: any[]) {
     Logger.trace(lazy`${target.constructor.name}.${propertyKey}: entry`)
-    Logger.debug(
-      lazy`${target.constructor.name}.${propertyKey}: arguments : ${stringify(args)}`
-    )
 
     const call = () => original.call(this, ...args)
 
     const logResult = (result: any) => {
-      Logger.debug(
-        lazy`${target.constructor.name}.${propertyKey}: result : ${stringify(result)}`
-      )
       Logger.trace(lazy`${target.constructor.name}.${propertyKey}: exit`)
       return result
     }

test/unit/service/MetadataService.test.ts

@@ -587,6 +587,12 @@ describe('MetadataService', () => {
           testObject: { fullName: 'TestCustomFieldValue' },
           expected: 'TestCustomFieldValue',
         },
+        {
+          name: 'handles valueSettings with valueName (CustomField)',
+          metadataType: 'valueSettings',
+          testObject: { valueName: 'TestValueSetting' },
+          expected: 'TestValueSetting',
+        },
       ]
 
       it.each(testCases)('$name', ({ metadataType, testObject, expected }) => {