Migrate inline_call assist to SyntaxFactory#22352
Open
lukasmatta wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
lukasmatta
force-pushed
the
migrate-inline-call-syntax-factory
branch
from
42b6221 to
5295623
Compare
Shourya742
reviewed
May 13, 2026
Author
Thanks for the feedback, I tried to address it, let me know if I'm on the right track. |
ChayimFriedman2
requested changes
May 15, 2026
|
|
||
| let params = get_fn_params(ctx.sema.db, function, ¶m_list)?; | ||
| let def_file_editor = SyntaxEditor::new( | ||
| ast_func.syntax().ancestors().last().unwrap_or_else(|| ast_func.syntax().clone()), |
Contributor
There was a problem hiding this comment.
Suggested change
| ast_func.syntax().ancestors().last().unwrap_or_else(|| ast_func.syntax().clone()), | |
| ast_func.syntax().ancestors().last().unwrap(), |
There is always a top ancestor (maybe we should have a method for that).
Author
There was a problem hiding this comment.
addressed (did not attempt to introduce a new method in this PR, frankly I'd need a guidance where would be the best place for such a method to live)
| .0; | ||
| let params = get_fn_params(ctx.sema.db, function, ¶m_list, &def_file_editor)?; | ||
|
|
||
| let mut file_editors: FxHashMap<FileId, SyntaxEditor> = FxHashMap::default(); |
Contributor
There was a problem hiding this comment.
Suggested change
| let mut file_editors: FxHashMap<FileId, SyntaxEditor> = FxHashMap::default(); | |
| let mut file_editors = FxHashMap::default(); |
| } | ||
| let params = get_fn_params(ctx.sema.db, function, ¶m_list)?; | ||
| let syntax = call_info.node.syntax().clone(); | ||
| let editor = SyntaxEditor::new(syntax.ancestors().last().unwrap_or_else(|| syntax.clone())).0; |
Contributor
There was a problem hiding this comment.
Suggested change
| let editor = SyntaxEditor::new(syntax.ancestors().last().unwrap_or_else(|| syntax.clone())).0; | |
| let editor = SyntaxEditor::new(syntax.ancestors().last().unwrap()).0; |
| db: &'db dyn HirDatabase, | ||
| function: hir::Function, | ||
| param_list: &ast::ParamList, | ||
| file_editor: &SyntaxEditor, |
Contributor
There was a problem hiding this comment.
Given this only uses make, better to pass only it.
lukasmatta
force-pushed
the
migrate-inline-call-syntax-factory
branch
from
9dbf0e4 to
74af81d
Compare
This comment has been minimized.
This comment has been minimized.
lukasmatta
force-pushed
the
migrate-inline-call-syntax-factory
branch
from
74af81d to
ad15548
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
lukasmatta
force-pushed
the
migrate-inline-call-syntax-factory
branch
from
ad15548 to
3efd9b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the two remaining
make::calls inget_fn_params.Part of #18285.