Skip to content

Support Reborrow and CoerceShared built-in derives#22325

Open
P8L1 wants to merge 4 commits into
rust-lang:masterfrom
P8L1:derive-reborrow-coerce-shared
Open

Support Reborrow and CoerceShared built-in derives#22325
P8L1 wants to merge 4 commits into
rust-lang:masterfrom
P8L1:derive-reborrow-coerce-shared

Conversation

@P8L1
Copy link
Copy Markdown

@P8L1 P8L1 commented May 9, 2026

This adds rust-analyzer support for the experimental built-in derives Reborrow and CoerceShared.

This was split out from rust-lang/rust#156338 after review feedback that rust-analyzer changes should be made in the rust-analyzer repository rather than through the rust-lang/rust subtree.

Related:

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2026
@P8L1
Copy link
Copy Markdown
Author

P8L1 commented May 9, 2026

r? @ChayimFriedman2

Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to wait until the rust-lang/rust PR is merged.

View changes since this review

Comment thread crates/hir-expand/src/builtin/derive_macro.rs Outdated
Comment thread crates/hir-def/src/builtin_derive.rs Outdated
Comment thread crates/hir-def/src/builtin_derive.rs Outdated
Comment thread crates/hir-ty/src/builtin_derive.rs Outdated
P8L1 and others added 2 commits May 10, 2026 00:12
@P8L1 P8L1 requested a review from ChayimFriedman2 May 9, 2026 22:30
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as I said I want to wait for the rust-lang/rust PR to merge.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants