fix: Don't write to tmpdir in CI#207
Merged
epage merged 10 commits intorust-cli:masterfrom Mar 31, 2026
Merged
Conversation
Skip writing to temporary file in CI which is then typically inaccessible from an already failed CI job. In those cases, it's better to dump directly to stderr, since that'll typically be captured by console logging. Inspired by zizmor
epage
force-pushed
the
ci
branch
4 times, most recently
from
9444679 to
f23f43e
Compare
epage
added a commit
to epage/zizmor
that referenced
this pull request
Mar 31, 2026
I mirrored the idea of what zizmor does in rust-cli/human-panic#207, making it so that this check wouldn't be needed anymore. Fixes zizmorcore#1838
2 tasks
woodruffw
added a commit
to zizmorcore/zizmor
that referenced
this pull request
Apr 1, 2026
* refactor: Leverage human-panic for CI-specialized logic I mirrored the idea of what zizmor does in rust-cli/human-panic#207, making it so that this check wouldn't be needed anymore. Fixes #1838 * Re-lock Signed-off-by: William Woodruff <william@yossarian.net> --------- Signed-off-by: William Woodruff <william@yossarian.net> Co-authored-by: William Woodruff <william@yossarian.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip writing to temporary file in CI
which is then typically inaccessible from an already failed
CI job. In those cases, it's better to dump directly to stderr,
since that'll typically be captured by console logging.
Inspired by zizmor