Fix #256: Change pinocchio jacobian frame from LOCAL to LOCAL_WORLD_ALIGNED to match KDL#257
Fix #256: Change pinocchio jacobian frame from LOCAL to LOCAL_WORLD_ALIGNED to match KDL#257baconbrot wants to merge 1 commit into
Conversation
…o jacobian calculation to match KDL result
|
Now there is a problem with the EXPECT_THAT(delta_x, MatrixNear(delta_x_est, 0.02));It seems that the pinocchio WORLD frame is not updated to be coincident with the new root link frame of the urdf. If this is correct, then all methods from the pinocchio implementation need additional transformations to be in the correct frame (i.e. rotations for jacobian and rotation+translation for link_transform). |
|
I haven't used pinocchio that much, but I remember that I had to deal with such problems it when I ported the pinocchio plugin to this repository. Why did the tests succeed earlier with the old pinocchio method? |
Description
See #256
Is this user-facing behavior change?
Yes, if a user is using the pinocchio plugin. The update will break their code and may cause unpredictable robot motions.
Did you use Generative AI?
Claude Code with Sonnet 4.6 for documentation, reference and code queries (i.e. KDL and pinocchio docu and source code lookups).
Additional Information
Adds an additional test to validate that all (current and future) kinematics_interface plugin implementations calculate the same results.
TODOs