docs: refresh current project stats#330
Conversation
|
@honor2030 is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughUpdates README and AGENTS.md statistics (tests, tools, endpoints), updates src/index.ts boot log endpoint count, and adds a test that computes REST endpoint count from src/triggers/api.ts and asserts that count appears in README.md, AGENTS.md, and src/index.ts. ChangesDocumentation and endpoint consistency
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 910: The README badge showing "104 endpoints" is stale; update the badge
text/count in README.md to match the current number of REST endpoints (change
"104 endpoints" to "107 endpoints") and ensure the same source-of-truth changes
were applied: verify triggers/api.ts has the new endpoints registered and
index.ts contains the updated endpoint count in its log line so all three places
(triggers/api.ts, index.ts, and README.md) remain consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 49b8c316-a7c6-4a38-be93-0ebf82ca45bc
⛔ Files ignored due to path filters (2)
assets/tags/light/stat-tests.svgis excluded by!**/*.svgassets/tags/stat-tests.svgis excluded by!**/*.svg
📒 Files selected for processing (2)
AGENTS.mdREADME.md
9a2d7f9 to
b8539ac
Compare
|
Addressed the stale stats feedback in the latest push (
Verification:
Current checks after push: CodeRabbit is passing/skipped. Vercel remains blocked by repository deployment authorization, unrelated to this PR diff. |
b8539ac to
1deb330
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
test/consistency.test.ts (1)
51-60: 💤 Low valueConsider adding a sanity check for the endpoint count.
The test currently only verifies that
restEndpointCount > 0, which is a very weak assertion. Based on the PR context (107-121 endpoints), a more realistic lower bound would catch gross counting errors if the regex fails catastrophically.Optional: Add a realistic minimum bound
- expect(restEndpointCount).toBeGreaterThan(0); + expect(restEndpointCount).toBeGreaterThan(100); // Sanity check: should have 100+ endpoints expect(readme).toContain(`${restEndpointCount} endpoints on port`);This would catch scenarios where the regex completely fails and only matches a handful of patterns.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/consistency.test.ts` around lines 51 - 60, The test "documented REST endpoint counts match registered API paths" uses restEndpointCount > 0 which is too weak; update the assertions to include a realistic minimum bound (e.g., expect(restEndpointCount).toBeGreaterThanOrEqual(100)) to catch catastrophic regex failures while keeping the existing comparisons against README/AGENTS/index; locate the test block that contains restEndpointCount and replace or augment the expect(restEndpointCount).toBeGreaterThan(0) with a stronger check (toBeGreaterThanOrEqual with a value around 100 based on current PR counts).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@test/consistency.test.ts`:
- Around line 51-60: The test "documented REST endpoint counts match registered
API paths" uses restEndpointCount > 0 which is too weak; update the assertions
to include a realistic minimum bound (e.g.,
expect(restEndpointCount).toBeGreaterThanOrEqual(100)) to catch catastrophic
regex failures while keeping the existing comparisons against
README/AGENTS/index; locate the test block that contains restEndpointCount and
replace or augment the expect(restEndpointCount).toBeGreaterThan(0) with a
stronger check (toBeGreaterThanOrEqual with a value around 100 based on current
PR counts).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 45bd188c-fba2-460e-84f4-ef1e39059a72
⛔ Files ignored due to path filters (2)
assets/tags/light/stat-tests.svgis excluded by!**/*.svgassets/tags/stat-tests.svgis excluded by!**/*.svg
📒 Files selected for processing (4)
AGENTS.mdREADME.mdsrc/index.tstest/consistency.test.ts
✅ Files skipped from review due to trivial changes (2)
- src/index.ts
- AGENTS.md
Summary
AGENTS.mdstats from v0.9.12-era values to v0.9.16950+ testslabel and fix stale50/107countssrc/triggers/api.tsEvidence
npx tsx -e "import { getAllTools } from './src/mcp/tools-registry.ts'; console.log(getAllTools().length);"→51python3count ofapi_pathentries insrc/triggers/api.ts→121AGENTMEMORY_URL=http://127.0.0.1:9 AGENTMEMORY_PROBE_TIMEOUT_MS=50 npm test→87 passed,955 passedTest Plan
npm run buildAGENTMEMORY_URL=http://127.0.0.1:9 AGENTMEMORY_PROBE_TIMEOUT_MS=50 npx vitest run test/consistency.test.tsAGENTMEMORY_URL=http://127.0.0.1:9 AGENTMEMORY_PROBE_TIMEOUT_MS=50 npm testgit diff --checkRefs docs hygiene follow-up; does not change runtime behavior except the human-readable startup endpoint count.
Summary by CodeRabbit