Skip to content

Include keypoints_metadata.json when uploading model#478

Open
grzegorz-roboflow wants to merge 2 commits into
mainfrom
fix/include-keypoints-metadata-json-on-model-upload
Open

Include keypoints_metadata.json when uploading model#478
grzegorz-roboflow wants to merge 2 commits into
mainfrom
fix/include-keypoints-metadata-json-on-model-upload

Conversation

@grzegorz-roboflow
Copy link
Copy Markdown
Contributor

What does this PR do?

Include keypoints_metadata.json when uploading model, so users can upload keypoint models

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

Tested locally

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

N/A

Copy link
Copy Markdown
Collaborator

@tonylampada tonylampada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

there's improvement suggestion from 🤖 review that might be worth looking into:

a user deploying a pose model from a directory that lacks keypoints_metadata.json gets a successful upload acknowledgment but a broken deployed model — with no feedback about what went wrong.

This is a "should fix before merge" concern, not a blocker, because the PR already improves the status quo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants