fix: pass 'column' argument to CreateAction mutateDataUsing#124
Merged
ManukMinasyan merged 3 commits intoMay 12, 2026
Merged
Conversation
According to the documentation, the CreateAction should receive the 'column' identifier inside the $arguments array in the mutateDataUsing method. This fix ensures the column argument is properly passed down to the action, allowing developers to know which column triggered the creation.
…ctions Reproduces issue relaticle#124: a CreateAction registered via columnActions() on a BoardResourcePage previously dropped the wire:click `column` argument, so mutateDataUsing() callbacks received an empty arguments array. The fix in 0a7df87 now mirrors upstream InteractsWithActions::resolveActions() and propagates arguments via mergeArguments(). Adds: - TestResource + TestBoardResourcePage fixtures - SchemasServiceProvider registration in TestCase (needed for assertSchemaExists macro) - Pest test using Filament's TestAction macro to call the column action with column=in_progress and assert the created Task lands in the right column
mutateFormDataUsing was deprecated in Filament 5 in favour of mutateDataUsing. Both go through the same code path, so this is a pure naming swap.
Contributor
|
Thanks @eduardoribeirodev! Merged and shipped in v4.0.12. Added a regression test on top so the column argument stays wired up. |
ManukMinasyan
added a commit
that referenced
this pull request
May 12, 2026
) * fix: pass 'column' argument to CreateAction mutateDataUsing According to the documentation, the CreateAction should receive the 'column' identifier inside the $arguments array in the mutateDataUsing method. This fix ensures the column argument is properly passed down to the action, allowing developers to know which column triggered the creation. * test: cover column argument propagation on BoardResourcePage column actions Reproduces issue #124: a CreateAction registered via columnActions() on a BoardResourcePage previously dropped the wire:click `column` argument, so mutateDataUsing() callbacks received an empty arguments array. The fix in 0a7df87 now mirrors upstream InteractsWithActions::resolveActions() and propagates arguments via mergeArguments(). Adds: - TestResource + TestBoardResourcePage fixtures - SchemasServiceProvider registration in TestCase (needed for assertSchemaExists macro) - Pest test using Filament's TestAction macro to call the column action with column=in_progress and assert the created Task lands in the right column * docs: use mutateDataUsing in column action examples mutateFormDataUsing was deprecated in Filament 5 in favour of mutateDataUsing. Both go through the same code path, so this is a pure naming swap. * ci: open changelog PR instead of pushing to protected branch The release-triggered Changelog workflow was pushing the CHANGELOG.md update directly to 4.x via stefanzweifel/git-auto-commit-action. Branch protection on 4.x ("Changes must be made through a pull request") rejects that push, so every release since v4.0.10 has shipped without its CHANGELOG entry. Swap the commit-and-push step for peter-evans/create-pull-request, which opens a PR from chore/changelog-<tag> with the skip-changelog label, then enable auto-merge (squash) so the PR lands without human intervention. 4.x has no required status checks and 0 required reviews, so auto-merge clears immediately. Also tag the PR with skip-changelog so it's excluded from the next release's auto-generated notes (per .github/release.yml). --------- Co-authored-by: Eduardo Ribeiro <eduribeiro.films@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes an issue where the
columnargument was missing from the$argumentsarray in theCreateAction'smutateDataUsingmethod.Why is this needed?
The package documentation implies that when triggering a
CreateActionfrom a specific column in the BoardResourcePage board, the developer should be able to capture the column's identifier to automatically assign the status/column ID to the new record.Without this fix,
$arguments['column']is undefined, requiring workarounds.Example of what is now possible:
Checklist: