Skip to content

Use XNN fused RoPE for HF-style RoPE patterns#18627

Draft
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:xnn-rope
Draft

Use XNN fused RoPE for HF-style RoPE patterns#18627
GregoryComer wants to merge 1 commit intopytorch:mainfrom
GregoryComer:xnn-rope

Conversation

@GregoryComer
Copy link
Copy Markdown
Member

Summary

Pattern match HF style RoPE and delegate to XNNPACK. Relax slice constraints and add unsqueeze, as well, since XNNPACK supports them and it's easiest to not have to conditionally partition them for RoPE only when fusable.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18627

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Awaiting Approval, 5 New Failures, 2 Unrelated Failures

As of commit 1594c71 with merge base aa7c8ce (image):

AWAITING APPROVAL - The following workflow needs approval before CI can run:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant